Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VersionStream for percona-server-9.0 #35288

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Nov 26, 2024

No description provided.

Copy link
Contributor Author

octo-sts bot commented Nov 26, 2024

Gen AI suggestions to solve the build error:

Based on the error message, I'll provide a detailed analysis and solution:

• Detected Error:

warning: Could not find remote branch Percona-Server-9.0-1 to clone.
fatal: Remote branch Percona-Server-9.0-1 not found in upstream origin

• Error Category: Version/Git checkout error

• Failure Point:
The git checkout step in the pipeline when attempting to clone the specific tag

• Root Cause Analysis:
The error occurs because the git-checkout step is trying to use the tag as a branch name. The format of the tag being used doesn't match the actual tag format in the Percona Server repository.

• Suggested Fix:
Modify the tag format in the melange YAML. The correct tag format for Percona Server 9.0.1 should be "PS-9.0.1":

  - uses: git-checkout
    with:
      repository: https://github.com/percona/percona-server
      tag: PS-9.0.1
      expected-commit: d5292ef1219a4bb3dcc788ba6bd2034d0bcf6e3c
      recurse-submodules: true

Also update the var-transforms section accordingly:

var-transforms:
  - from: ${{package.version}}
    match: '(\d+\.\d+\.\d+)'
    replace: 'PS-$1'
    to: mangled-package-version

• Explanation:
Percona Server uses a different tag naming convention than what was assumed. They prefix their tags with "PS-" followed by the version number. This change aligns the checkout request with the actual tag format in their repository.

• Additional Notes:

  • You can verify the correct tag format by checking the Percona Server GitHub repository tags
  • The expected-commit hash should still be valid as it references the same commit
  • Make sure to keep the recurse-submodules flag as true since Percona Server uses submodules

• References:

@hbh7 hbh7 self-assigned this Dec 9, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 9, 2024

Gen AI suggestions to solve the build error:

Based on the error output, I can provide a specific analysis and solution:

• Detected Error:

warning: Could not find remote branch Percona-Server-9.0-1 to clone.
fatal: Remote branch Percona-Server-9.0-1 not found in upstream origin

• Error Category: Version/Git checkout

• Failure Point: Git checkout step trying to fetch tag "Percona-Server-9.0-1"

• Root Cause Analysis:
The build is failing because it's trying to checkout a non-existent tag "Percona-Server-9.0-1". The tag format in the repository appears to be different from what's being requested.

• Suggested Fix:

  1. Modify the var-transforms section to match the correct tag format:
var-transforms:
  - from: ${{package.version}}
    match: '(\d+\.\d+)\.(\d+)$'
    replace: "-$1-$2"
    to: mangled-package-version

This will transform "9.0.1" into "PS-9.0-1" which matches Percona's tagging convention.

• Explanation:
Percona Server uses a different tag format than what's currently being generated. The actual tags in their repository follow the pattern "PS-X.Y-Z" rather than "Percona-Server-X.Y-Z". The modified transform will correctly map the version number to the expected tag format.

• Additional Notes:

  • You can verify the correct tag format by checking the Percona Server GitHub repository tags
  • The repo uses "PS-" prefix for its release tags
  • Make sure to verify the exact commit hash matches the intended version

• References:

@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 9, 2024
@hbh7 hbh7 requested a review from a team December 9, 2024 23:27
@debasishbsws debasishbsws merged commit e8df570 into main Dec 10, 2024
13 of 14 checks passed
@debasishbsws debasishbsws deleted the percona-server-9.0 branch December 10, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. service:version-stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants